Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix insert function #6445

Merged
merged 2 commits into from
Jul 8, 2021
Merged

[fix] fix insert function #6445

merged 2 commits into from
Jul 8, 2021

Conversation

daybrush
Copy link
Contributor

Fixes #6444

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Sorry, something went wrong.

@benmccann
Copy link
Member

It'd be easier to review and make a cleaner git history if you sent the formatting changes as a separate PR

@daybrush
Copy link
Contributor Author

@benmccann

I'm sorry. editorconfig worked automatically.

Only one line changed here.

286cd1f#diff-7ad300a4efc821b2576200a7bfc99205d558792b81c037fbc20f9236f8b6f1bbR135

- } else if (node.parentNode !== target || (anchor && node.nextSibling !== anchor)) {
+ } else if (node.parentNode !== target || node.nextSibling !== anchor) {

@daybrush
Copy link
Contributor Author

@benmccann

Revert formatting?

@benmccann benmccann changed the title fix: fix insert function [fix] fix insert function Jun 30, 2021
src/runtime/internal/dom.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a problem with keyed each.
4 participants