[feat] a11y: add aria-proptype validation #6316
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #820, this is an attempt to begin adding support for validating
aria-proptypes
.I'm starting small because I wanted to open a PR as a discussion point to verify that I'm going about this the right way. I suspect if the approach looks good it will be easy to continue to add support for all the cases that are validated by the aria-query props mapI just went ahead and finished the all the proptype validations 🤓I had considered adding that library, but then saw that the core compiler seems to be fairly light on dependencies.
I wasn't sure how granular to make the test partitions seeing as there a large number of these proptypes, as a start I placed tests grouped into categories that the W3C taxonomy page lists: https://www.w3.org/TR/wai-aria/#state_prop_taxonomy
Before submitting the PR, please make sure you do the following
Tests
npm test
and lint the project withnpm run lint