Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first argument to writable could be optional #6294

Conversation

hunnble
Copy link
Contributor

@hunnble hunnble commented May 4, 2021

finish feature request at #6291
Only implement optional first argument for writable. It's unnecessary and inappropriate for readable.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@ignatiusmb
Copy link
Member

It's unnecessary and inappropriate for readable

How and why is it "inappropriate"?

Have you tried to check existing PRs before opening a new one? I suppose you do because this seems really similar to the PR exactly one number below. Why not help review the earlier PR and give your opinions why you deem it "unnecessary and inappropriate"?

@hunnble
Copy link
Contributor Author

hunnble commented May 4, 2021

It's unnecessary and inappropriate for readable

How and why is it "inappropriate"?

Have you tried to check existing PRs before opening a new one? I suppose you do because this seems really similar to the PR exactly one number below. Why not help review the earlier PR and give your opinions why you deem it "unnecessary and inappropriate"?

The second argument of readable API(start/stop notifier) is required.I notice you made both first and second arguments optional, could you give a example when should we call readable() without these two arguments?

The first argument is allowed empty already(readable(undefined, startFn)).I saw issue #6291 and made a simple TS update for writable API, then i realized you've made it too...still not sure it's necessary to change readable API.

@dummdidumm
Copy link
Member

This was fixed in #6293 , thank you for your contribution!

@dummdidumm dummdidumm closed this Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants