work around publishing issue with npm v7 #5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a horrible solution but I don't know what else to do now that will maintain the
preparescript, maintain the separate quick build and bundled/REPL-compatible for-publishing build, and also work on Windows.This adds another step to
prepublishOnlywhich ensures thatPUBLISHis already set. If you set it yourself, then it will still be inherited by the extraprepare-triggered build, and so the good build we want to publish won't be clobbered by a bad build.Works around #5662, but I would want to keep that issue open even if this were merged.