downgrade invalid callee error for event handlers to a warning #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #579.
One thing is that this does downgrade the error to a warning for
<:Window>
components as well. Arguably we know exactly what's available on the<:Window>
component and so perhaps that should still be an error. We could add an additional boolean parameter tovalidateEventHandler
and pass in true/false invalidateElement
andvalidateWindow
so we know whether to make that an error or a warning. But that all seems a bit ugly and asymmetrical.