Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade invalid callee error for event handlers to a warning #580

Merged
merged 1 commit into from
May 21, 2017

Conversation

Conduitry
Copy link
Member

Fixes #579.

One thing is that this does downgrade the error to a warning for <:Window> components as well. Arguably we know exactly what's available on the <:Window> component and so perhaps that should still be an error. We could add an additional boolean parameter to validateEventHandler and pass in true/false in validateElement and validateWindow so we know whether to make that an error or a warning. But that all seems a bit ugly and asymmetrical.

@codecov-io
Copy link

Codecov Report

Merging #580 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          95       95           
  Lines        2779     2779           
=======================================
  Hits         2625     2625           
  Misses        154      154
Impacted Files Coverage Δ
src/validate/html/validateEventHandler.js 93.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e58bd0...4c74051. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 7c2fd8e into master May 21, 2017
@Rich-Harris Rich-Harris deleted the gh-579 branch May 21, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants