-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix order of html tags when if in key block #5685
fix order of html tags when if in key block #5685
Conversation
309d691
to
002ffa2
Compare
<div>Second</div> | ||
</section> | ||
|
||
<button on:click={changeNum}>Click</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint
enforces a new line at the end of files, but it looks like we have only set it up to run against js
and ts
files (probably because we have some .svelte
files in the test with purposefully malformed content for testing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint-plugin-svelte3 wouldn't complain about this anyway. The linting rules just apply to the parts that are JS (the script tags and the template expressions), and it doesn't extrapolate any of them to the component itself.
@benmccann I see you added the |
Ah, yeah. I didn't look that closely and assumed it was keyed each especially since it was the closest match. I didn't realize there was a key feature. We could add a new label, but I think the existing labels might be a bit granular and a better solution could be to come up with some higher-level categories for the labels to use |
Fixes #5680
Before submitting the PR, please make sure you do the following
Tests
npm test
and lint the project withnpm run lint