Use .querySelector(':checked') instead of .selectedOptions, enable several <select> tests #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539.
For better compatibility with older browsers (and jsdom before v10). I made a few changes to the tests which were previously disabled, resolving inconsistencies which I assume came about since they didn't run in the first place. You may wish to verify that my assumptions are accurate, though.
While I've updated it to add the
multipleattribute, thebinding-select-multipletest is still failing in jsdom. I think I may have found the cause and will investigate further.I've also tested the code in Firefox, Chrome and Safari. I'm not able to boot a Windows VM at the moment, so I'm hoping that IE and Edge behave as they should here.