Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix destructuring to get multiple stores #5390

Merged
merged 4 commits into from
Sep 15, 2020

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Sep 13, 2020

Fixes #5388

Root cause: from #4069, we skip $$invalidate calls if the assignment happen at the main execution context, this skips the subscribe_store instrumentation as well.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry Conduitry merged commit 1ce6ac5 into sveltejs:master Sep 15, 2020
@tanhauhau tanhauhau deleted the tanhauhau/gh-5388 branch September 15, 2020 13:04
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use destructuring assignment to get 2 stores from object, when variables declared with let
2 participants