Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typings to get_store_value #5269

Merged
merged 5 commits into from
Sep 29, 2020
Merged

Conversation

tanhauhau
Copy link
Member

Worked on top of #5194

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test)

@Conduitry Conduitry merged commit 2c5f1c4 into sveltejs:master Sep 29, 2020
@tanhauhau tanhauhau deleted the tanhauhau/gh-5194 branch September 29, 2020 18:05
@Conduitry
Copy link
Member

This has been released in 3.29.0.

taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants