Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set element's value attribute to default empty string if nothing is provided #5240

Closed
wants to merge 6 commits into from

Conversation

asvsfs
Copy link

@asvsfs asvsfs commented Aug 5, 2020

fix: #4467

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test)

@asvsfs asvsfs changed the title Input val Set element's value attribute to default empty string if nothing is provided . Aug 5, 2020
@asvsfs asvsfs marked this pull request as ready for review August 5, 2020 10:19
@Conduitry
Copy link
Member

What issue is this related to? What is this intended to fix?

@asvsfs
Copy link
Author

asvsfs commented Aug 5, 2020

What issue is this related to? What is this intended to fix?

@Conduitry
Forgot to mention ! it is related to #4467

@benmccann
Copy link
Member

can you rebase against master and make sure npm run lint passes? we just updated our eslint config to allow only single quotes

@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Jun 26, 2021
@stale stale bot removed the stale-bot label Jun 26, 2021
@pngwn pngwn added compiler Changes relating to the compiler stale-bot and removed feature: attributes temp-stale labels Jun 27, 2021
@stale stale bot removed the stale-bot label Jun 27, 2021
@benmccann
Copy link
Member

Just a reminder that this PR would need a rebase

@vercel
Copy link

vercel bot commented Mar 2, 2023

@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm
Copy link
Member

Looking at the compiler output, I think we should either remove the input.value = .. assignmed that happens in c() or adjust that one instead to use the set_input_value method. The way it's now is setting the value two times essentially.

@baseballyama baseballyama changed the title Set element's value attribute to default empty string if nothing is provided . fix: Set element's value attribute to default empty string if nothing is provided Mar 31, 2023
@dummdidumm dummdidumm added this to the one day milestone Apr 3, 2023
@Rich-Harris
Copy link
Member

Closing Svelte 4 PRs as stale — thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Changes relating to the compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined value on input and other elements
7 participants