Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{@html} moves for slot on update #5061

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

tanhauhau
Copy link
Member

Fixes #5012

  • added 2 more conditions that requires anchor for {@html}
    • as the root of a slot (parent is a component)
    • as the root of the template, with no siblings (parent is null)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test)

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5012 branch from 11225ab to 4284386 Compare June 24, 2020 11:41
@Conduitry Conduitry merged commit e1b55f0 into sveltejs:master Jun 24, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slot containing only {@html value} renders in wrong place on update
2 participants