-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spread condition for input element #5004
Merged
Conduitry
merged 3 commits into
sveltejs:master
from
tanhauhau:tanhauhau/spread-condition
Jul 7, 2020
Merged
spread condition for input element #5004
Conduitry
merged 3 commits into
sveltejs:master
from
tanhauhau:tanhauhau/spread-condition
Jul 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhauhau
force-pushed
the
tanhauhau/spread-condition
branch
from
June 12, 2020 05:54
3e930a0
to
9ac89ae
Compare
@tanhauhau Can you take a look at the conflict here please? In particular, we need to make sure the changes in #5054 are reflected in the code that this PR moves to another location. |
tanhauhau
force-pushed
the
tanhauhau/spread-condition
branch
from
June 24, 2020 07:30
9ac89ae
to
0dfcd19
Compare
antony
approved these changes
Jul 4, 2020
hontas
added a commit
to hontas/svelte
that referenced
this pull request
Jul 18, 2020
* upstream/master: (190 commits) invalidate $$props and $$restProps only when there are changes (sveltejs#5123) site: use https in link in blog (sveltejs#5148) Simplify each block bindings example (sveltejs#5094) fix $$props reactive for slots (sveltejs#5125) site: add FAQ entry for how to document a svelte component (sveltejs#5131) site: remove an obsolete TODO in blog post (sveltejs#5135) Increase timeout for unit build Increase timeout for unit tests -> v3.24.0 spread condition for input element (sveltejs#5004) update changelog fix(5018): compare wholeText instead of data (sveltejs#5028) html anchor in head (sveltejs#5071) error on expression scope store (sveltejs#5079) update changelog preprocess self-closing script and style tags (sveltejs#5082) update changelog fix: Parameters with default values are optional (sveltejs#5083) make builds time out after a reasonable period (sveltejs#5100) site: fix blog typo (sveltejs#5090) ...
hontas
added a commit
to hontas/svelte
that referenced
this pull request
Jul 18, 2020
* master: (67 commits) add updating guard to binding callback (sveltejs#5126) Bump lodash from 4.17.15 to 4.17.19 (sveltejs#5152) Bump lodash from 4.17.15 to 4.17.19 in /site (sveltejs#5155) Fixes sveltejs#5153 (sveltejs#5154) invalidate $$props and $$restProps only when there are changes (sveltejs#5123) site: use https in link in blog (sveltejs#5148) Simplify each block bindings example (sveltejs#5094) fix $$props reactive for slots (sveltejs#5125) site: add FAQ entry for how to document a svelte component (sveltejs#5131) site: remove an obsolete TODO in blog post (sveltejs#5135) Increase timeout for unit build Increase timeout for unit tests -> v3.24.0 spread condition for input element (sveltejs#5004) update changelog fix(5018): compare wholeText instead of data (sveltejs#5028) html anchor in head (sveltejs#5071) error on expression scope store (sveltejs#5079) update changelog preprocess self-closing script and style tags (sveltejs#5082) ...
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Wojmis3
added a commit
to Wojmis3/svelte
that referenced
this pull request
Sep 22, 2021
Didn't break what sveltejs#5004 fixed, hopefully didn't break anything else - no tests changed thei results after this change.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4418
When updating input.value, we check whether
input.value === value
before setting it:however we didnt check this when using spread:
this MR tries to fix this
I did some moving code around, so i can extract the logic from Attribute#render that handles the special case for
input.value
,input.src
,should_cache
, etc, still figuring out what's the best way to refactor them, suggestions welcome.Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)