turn fancybutton into custombutton #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
requested changes
Feb 26, 2020
|
Can you take a look at the test failure as well? It looks to be legitimate, but is only because of character offsets of warnings. |
|
Totally cowboyed it and didn't run tests as I was on my way out. Will fix
asap.
On Wed, 26 Feb 2020 at 22:16, Conduitry ***@***.***> wrote:
Can you take a look at the test failure as well? It looks to be
legitimate, but is only because of character offsets of warnings.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4476?email_source=notifications&email_token=AABVORLBL7Q2XDBQFK23WHLRE3S4NA5CNFSM4K4KMRV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCDLQA#issuecomment-591672768>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVORIGG6AEQ4RHIJ43XU3RE3S4NANCNFSM4K4KMRVQ>
.
--
…________________________________
ꜽ . antony jones . http://www.enzy.org
|
hontas
added a commit
to hontas/svelte
that referenced
this pull request
Mar 6, 2020
* 'master' of https://github.com/sveltejs/svelte: (137 commits) -> v3.19.2 fix lazy code breaks in build fit bitmask overflow initial dirty value in 'if' blocks (sveltejs#4507) add dev runtime warning for unknown slot names (sveltejs#4501) fix render fallback slot content due to whitespace (sveltejs#4500) docs: describe falsy and nullish attribute behavior (sveltejs#4498) in spread, distinguish never-updating and always-updating props (sveltejs#4487) chore: more specific typings, and add README note about Yarn (sveltejs#4483) update changelog check for unknown props even if component doesn't have writable props (sveltejs#4454) Bump codecov from 3.5.0 to 3.6.5 (sveltejs#4433) fix bitmask overflow for slot (sveltejs#4485) mark module variables as mutated or reassigned (sveltejs#4469) docs: referenced_from_script var value (sveltejs#4486) docs: clarify default prop behaviour (sveltejs#4460) site: turn fancybutton into custombutton (sveltejs#4476) update changelog exclude global variables from $capture_state (sveltejs#4475) -> v3.19.1 don't treat $$-names as stores during invalidation (sveltejs#4453) ...
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4462
Renamed FancyButton to CustomButton. I've also changed the styling into something that isn't better named UglyButton.
Before submitting the PR, please make sure you do the following
npm run lint!)Tests
npm testoryarn test)