make autosubscribing to a nullish store a no-op #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side effect of #4300, this would also mean that you're allowed to use nullish values as dependencies in derived stores, and they'll just be treated as stores containing |
jesseskinner
pushed a commit
to jesseskinner/svelte
that referenced
this pull request
Feb 27, 2020
* make autosubscribing to a nullish store a no-op (sveltejs#2181) * update changelog * add test
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
* make autosubscribing to a nullish store a no-op (sveltejs#2181) * update changelog * add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2181.
This adds a very slight cost in terms of per-app bytes (and adds an extra
== nulltest each time we subscribe to a component via thesubscribe()helper) - and it's possible that this will mask genuine bugs or logic errors in components - but I still think we're better off with this.With this PR, you're allowed to have autosubscribed stores that don't immediately have values, which, in addition to what's described in #2181, also lets you more easily use a series of reactive declarations to grab something from nested stores.
If this is merged, we should probably also document the new behavior somewhere beyond the changelog, but I'm not sure where.