Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reinstate comments #3870

Merged
merged 4 commits into from
Nov 9, 2019
Merged

reinstate comments #3870

merged 4 commits into from
Nov 9, 2019

Conversation

Rich-Harris
Copy link
Member

@Conduitry
Copy link
Member

Something else I just thought of is preserving comments from the component's source <script>s. This seems to be done inconsistently in @latest but it looks like they are all lost in @next. I'm not sure what the old behavior is exactly, or whether trying to match that is the goal.

@Rich-Harris Rich-Harris marked this pull request as ready for review November 9, 2019 18:07
@Rich-Harris
Copy link
Member Author

For now I'm thinking just the comments added by Svelte — we could include user comments as well but it'd be a bit hacky

@Rich-Harris Rich-Harris changed the title [WIP] reinstate comments reinstate comments Nov 9, 2019
@Rich-Harris Rich-Harris merged commit 4ffa6fc into master Nov 9, 2019
@Rich-Harris Rich-Harris deleted the gh-3855 branch November 9, 2019 19:50
@Conduitry Conduitry mentioned this pull request Nov 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @Conduitry