fix input binding fails if type declared last #3849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3828
If type attribute is declared after the binding, evaluating
parent.get_static_attribute_value('type')
inBinding
returnsnull
because type hasn't been pushed to the attributes list. As a result,type
is null andtype === 'file'
is false, which is used to determine whether it's readonly and to prevent assigninginput.files
.Forcing all
Attribute
s andSpread
s to be evaluated beforeBinding
can fix the issue, and I suppose it does not create any kind of side effect. Let me know if there's any problem may arise that I'm not aware of.Really appreciate for your review!
Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)