Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconflict shared helpers with user imports #306

Merged
merged 5 commits into from
Feb 28, 2017
Merged

Deconflict shared helpers with user imports #306

merged 5 commits into from
Feb 28, 2017

Conversation

Rich-Harris
Copy link
Member

Fixes one aspect of #222, wherein this...

<script>
  import { get } from 'ajax';
  export default {...};
</script>

...would create a conflict between the user's import and Svelte's built-in import in the case of shared helpers. Credit to @Swatinem who was right (as usual 😀 ) to point out that a method for creating helper aliases on-demand was the best way to use shared helpers.

@Rich-Harris Rich-Harris merged commit e486ed0 into master Feb 28, 2017
@Rich-Harris Rich-Harris deleted the gh-222-a branch February 28, 2017 20:29
@Swatinem
Copy link
Member

Yes, looks nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants