Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set quote_mark to null when closing quote mark is found #2754

Merged
merged 1 commit into from
May 15, 2019
Merged

Set quote_mark to null when closing quote mark is found #2754

merged 1 commit into from
May 15, 2019

Conversation

EmilTholin
Copy link
Member

Everything in the style attribute after the opening quote mark in url('... is included in the chunk text. This PR sets quote_mark to null when the closing quote mark is found.

Closes #2715

@Rich-Harris Rich-Harris merged commit 75a77fe into sveltejs:master May 15, 2019
@Rich-Harris
Copy link
Member

@EmilTholin on a roll 🤘

@EmilTholin EmilTholin deleted the reset-quote-mark branch May 15, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline styles with inner quotes have parsing issues
3 participants
@EmilTholin @Rich-Harris @Conduitry