Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address regression with untrack #15079

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: address regression with untrack #15079

merged 2 commits into from
Jan 21, 2025

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jan 21, 2025

Fixes #15077

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: c79c902

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15079

Copy link
Member

@paoloricciuti paoloricciuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird we didn't already had a test for this...did you check if any other active_reaction === null or active_reaction !== null or !active_reaction (or stuff like that, you get the gist) needs to be updated? I think we were checking in a lot of places right?

@trueadm
Copy link
Contributor Author

trueadm commented Jan 21, 2025

Weird we didn't already had a test for this...did you check if any other active_reaction === null or active_reaction !== null or !active_reaction (or stuff like that, you get the gist) needs to be updated? I think we were checking in a lot of places right?

This is the only location actually. It came straight to me when I saw the issue because of the fact it was creating state inside a class and then reading it right after.

@trueadm trueadm merged commit 09510c8 into main Jan 21, 2025
11 checks passed
@trueadm trueadm deleted the fix-untracking-bug branch January 21, 2025 20:01
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
@paoloricciuti
Copy link
Member

This is the only location actually. It came straight to me when I saw the issue because of the fact it was creating state inside a class and then reading it right after.

Great 🤟🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.19.1 breaks untrack
3 participants