Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat inert as a boolean attribute #14935

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix: treat inert as a boolean attribute #14935

merged 2 commits into from
Jan 7, 2025

Conversation

dummdidumm
Copy link
Member

fixes #14731

Not sure how/when we regressed from #7785

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 6d58e45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14935-svelte.vercel.app/

this is an automated message

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Playground

pnpm add https://pkg.pr.new/svelte@14935

@Rich-Harris Rich-Harris merged commit 8241096 into main Jan 7, 2025
11 checks passed
@Rich-Harris Rich-Harris deleted the inert-fix branch January 7, 2025 19:24
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inert=false still added to element during server side rendering
2 participants