fix: transform everything that is not a selector inside :global

[paoloricciuti]

Closes #14568

I'm not entirely sure if there's a better way: i think keyframes are the only thing transformed that are not selectors but this should make sure that we transform everything, we just don't touch the selectors.

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• Prefix your PR title with feat:, fix:, chore:, or docs:.
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.
• If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

• Run the tests with pnpm test and lint the project with pnpm lint

[changeset-bot]

🦋 Changeset detected

Latest commit: ed4f62d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Rich-Harris]

preview: https://svelte-dev-git-preview-svelte-14577-svelte.vercel.app/

this is an automated message

[github-actions]

Playground

pnpm add https://pkg.pr.new/svelte@14577

[dummdidumm]

If it's only the keyframes, what about creating a zimmerframe walker just for that, and call that in this case?

const keyframes = {
  WhatEverSelectorIsNeededForThat(node) {
    if (needsToScopeSelector) { doIt }
  }
}

// ...
if (node.metadata.is_global_block) {
  // ...
  walk(node.block, null, keyframes)
}

[paoloricciuti]

If it's only the keyframes, what about creating a zimmerframe walker just for that, and call that in this case?

const keyframes = {
  WhatEverSelectorIsNeededForThat(node) {
    if (needsToScopeSelector) { doIt }
  }
}

// ...
if (node.metadata.is_global_block) {
  // ...
  walk(node.block, null, keyframes)
}

That's a good idea but i wonder if it's not better to do this like this so that it's not an "edge case" and even if there's something else that get's transformed it will be transformed anyway.

[paoloricciuti]

I think I wrote my answer very bad lol. The point is: this will technically transform everything that is not a selector. If we specifically target key frames we will fix this bug but we might discover new edge cases or, if we add new transforms in the future, we have to add it to the special case. Considering this is not to hairy maybe is the better solution? I'm a bit thorned

[7antra]

Thanks

[paoloricciuti]

This should lay some ground to also fix #14616

[ai]

Seems like this PR broke disabling animation isolation #14713

[paoloricciuti]

Seems like this PR broke disabling animation isolation #14713

Yup, technically there are workaround to that but we need to fix it

[ai]

@paoloricciuti what is a way to prevent it? Use :global() in selector for each rule?

[paoloricciuti]

@paoloricciuti what is a way to prevent it? Use :global() in selector for each rule?

Yeah...but I think the important bit is just the one with the animation

[paoloricciuti]

Anyway I'll try to fix this asap

[ai]

@paoloricciuti I try to draft some fix if it could help #14822