Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default values for form elements #14289

Merged
merged 18 commits into from
Dec 4, 2024
Merged

feat: default values for form elements #14289

merged 18 commits into from
Dec 4, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 13, 2024

WIP

closes #8220
closes #9230

This implements default values for form elements. These default values take effect when the reset method of the surrounding form is invoked.

  • for input with value/checked it's defaultValue/defaultChecked
  • for input with bind:group it's checked (hydration not working yet, not working for dynamic yet) no handling for bind:group, because too confusing / limiting
  • for select it's selected on the option elements (hydration not working yet, not working for dynamic yet)
  • defaultValue/defaultChecked on the server -> use if value undefined/falsy? -> not for now

Open questions:

  • for defaultValue/defaultChecked the value of that takes precedence on the initial render in case the value/checked value is undefined/null. That also means that in case of bind:value/checked the default value will be propagated back to that variable. Ok?
    • ok
  • In case that's ok, should we do the same for bind:group? It's tricky there because for a group of checkboxes, we currently require an array to be set (else you get runtime errors), and so the value isn't falsy, and the empty array could be on purpose / hard to say if the default checked should take precedence there initially
    • no handling for bind:group. That binding is kinda special in many ways and with bind:checked={get, set} we can likely provide a more robust/scalable/working across components solution anyway
  • Same question for bind:value on selects with multiple, with same problem as for bind:group on checkboxes
    • for multiple the initial selection is ignored, i.e. the array takes precedence

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: d4e836b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14289-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14289

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like <select> elements aren't being reset correctly? I have to press the reset button twice for the state to update, even though the select itself updates immediately

@Rich-Harris Rich-Harris marked this pull request as ready for review December 4, 2024 14:46
@Rich-Harris Rich-Harris merged commit a57e747 into main Dec 4, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the default-values branch December 4, 2024 14:47
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants