Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't access requestAnimationFrame eagerly #14026

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: don't access requestAnimationFrame eagerly #14026

merged 1 commit into from
Oct 30, 2024

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Oct 29, 2024

closes #13961

allows testing some browser code without jsdom

performance-wise these are equivalent because rollup will replace BROWSER and evaluate the ternary at compilation time

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 3294923

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 29, 2024

pnpm add https://pkg.pr.new/svelte@14026

commit: 3294923

@trueadm trueadm merged commit 08bc37a into main Oct 30, 2024
10 checks passed
@trueadm trueadm deleted the lazy-raf branch October 30, 2024 09:23
@dummdidumm
Copy link
Member

This should've had a comment explaining why we do that

@benmccann
Copy link
Member Author

changeset too. sent a PR for those here: #14040

dummdidumm pushed a commit that referenced this pull request Oct 30, 2024
@PierBover
Copy link

PierBover commented Oct 30, 2024

Is there a way to disable this behavior?

5.1.5 completely broke our Svelte 5 app. It all works as expected with 5.1.4 and previous versions.

I've been looking at the changes of 5.1.5 and this is the only new thing that could have impacted us.

I would like to test if this is indeed the issue.

Edit:

The issue is related to snippets and 5.1.5. I'm creating a repro and will open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteSet does not behave correctly in Vitest
4 participants