attempts to fix #1331 #1332
Closed
attempts to fix #1331 #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might not be the cleanest way, but at least it handles the logic adequately.
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
+ Coverage 91.72% 91.72% +<.01%
==========================================
Files 125 125
Lines 4472 4473 +1
Branches 1401 1401
==========================================
+ Hits 4102 4103 +1
Misses 146 146
Partials 224 224
Continue to review full report at Codecov.
|
|
Thanks for the PR! This isn't quite the right fix though — I'll close this in favour of #1333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #1331
Might not be the cleanest way, but at least it handles the logic adequately.
Interesting that the regression did not trigger a test failure. I will look into it...