fix: address regressed memory leak #11832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0789638 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially reverts #11752. As lovely as that PR was, it brought back the memory leak that #11197 solved. I should have noticed this when I reviewed the PR.
Essentially, the culprit is this #11752 (review). We cannot do this as it means we will retain references to DOM elements that might have been removed or changed from some other effect within. The memory leak is bad too, as we just end up retaining everything.
We can maybe come up with a nicer cleanup after this, but I want to remove this memory leak first.
If you'd like a repro case, render an each block with a few thousand elements. Then update and remove them all, notice how we retain all the each block elements in the parent effect because they're referenced in its
effect.domarray.