Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Rollup with shared helpers always includes transitionManager #593

Closed
Conduitry opened this issue May 23, 2017 · 1 comment · Fixed by #597
Closed

Using Rollup with shared helpers always includes transitionManager #593

Conduitry opened this issue May 23, 2017 · 1 comment · Fixed by #597
Labels

Comments

@Conduitry
Copy link
Member

This is probably technically in Rollup's court, but if there's anything we can do here to make the bundler behave better, that would be nice to do.

If you import any of the helpers in shared.js and bundle with Rollup with default settings, the transitionManager comes along too. I assume this has to do with it being an object instead of a function, and Rollup can't tell that it has no side effects.

FWIW, UglifyJS is able to discern that this is unneeded code and remove it, but Butternut is not. So maybe this is even in Butternut's court.

@Rich-Harris
Copy link
Member

Ah, curses. Rollup should be detecting and removing that. It might need to be written in a slightly different way.

Ideally Butternut would also detect and remove it, but the earlier it happens in the process the better.

Rich-Harris added a commit that referenced this issue May 27, 2017
Make transitionManager treeshakeable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants