-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-helper functions not deconflicted #388
Comments
This is also going to happen with <script>
import addCss from "./dummy";
</script>
<style>
</style> I don't think it can happen with anything else. Updating ticket description. |
Nope, also |
(Also The easiest way I could think of to handle this is with an extra flag passed to the |
Splitting off the alias generation into a separate method might be nicer than just adding a boolean argument to the existing method. |
PR #389 submitted, including unit test. |
…nctions Deconflict non helper functions
This is a bit of a weird case to handle, because while we do want to rename the
applyComputations
function if it conflicts with imports, we don't want to just use the existinghelper(name)
function, as that then adds the function to.uses
and we'd try to bring in the shared function by that name, which doesn't exist.Saving gists seems broken at the moment in the REPL, so here's a quick reproduction:
The text was updated successfully, but these errors were encountered: