Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object rest support #1540

Closed
TehShrike opened this issue Jun 13, 2018 · 3 comments · Fixed by #1628
Closed

Object rest support #1540

TehShrike opened this issue Jun 13, 2018 · 3 comments · Fixed by #1628

Comments

@TehShrike
Copy link
Member

The rest operator breaks the Svelte parser right now: https://svelte.technology/repl?version=2.7.2&gist=5cfe2e66a18895f0d8956fdd8ff45d0a

Maybe this would be fixed by bumping the acorn version? It's supposed to be supported in acorn ^5.4.1, but there have been some bug fixes to the spread operator since then, so who knows.

https://github.com/acornjs/acorn/blob/master/CHANGELOG.md
TehShrike added a commit to TehShrike/svelte that referenced this issue Jun 13, 2018
@TehShrike
Assert that the object rest operator parses in script tags
55d8636 
Trying to track down sveltejs#1540
@TehShrike TehShrike mentioned this issue Jun 13, 2018
Closed
@TehShrike
Copy link
Member Author

It's nothing to do with acorn, it's a bug in annotateWithScopes.ts. I tried to fix it but I have no clue what I'm doing :-P

@Rich-Harris Rich-Harris mentioned this issue Jun 13, 2018
Closed
Rich-Harris added a commit that referenced this issue Aug 4, 2018
@Rich-Harris
handle rest elements in computed properties - fixes #1540
7d55a57
@Rich-Harris Rich-Harris mentioned this issue Aug 4, 2018
Merged
@Rich-Harris
Copy link
Member

this is fixed in 2.9.10 (cc @PaulMaly)

@PaulMaly
Copy link
Contributor

@Rich-Harris Great! Thanks!

Rich-Harris added a commit that referenced this issue Oct 27, 2018
@Rich-Harris
Merge pull request #1628 from sveltejs/gh-1540
e35f174 
handle rest elements in computed properties
@dasDaniel dasDaniel mentioned this issue Dec 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle rest elements in computed properties sveltejs/svelte
3 participants
@TehShrike @Rich-Harris @PaulMaly