Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#snippet alter rendering behaviour of text inside svg #13793

Closed
matubu opened this issue Oct 22, 2024 · 1 comment · Fixed by #14134
Closed

#snippet alter rendering behaviour of text inside svg #13793

matubu opened this issue Oct 22, 2024 · 1 comment · Fixed by #14134

Comments

@matubu
Copy link
Contributor

matubu commented Oct 22, 2024 •
edited
Loading

Describe the bug

Whenever you use a snippet inside an SVG with SVG tags, the tags appear in the devtools but are not visible.

It's likely because the a tag is created in the wrong namespace
Maybe related: #13506

image

Reproduction

https://svelte.dev/playground/hello-world?version=5.0.5#H4sIAAAAAAAAA42Qz44CIQyHX4XUi5tsRK8jO3Fv-w7iYf50jVnsEOgYJ2TeXRjIevHgifK1fP2FAL8Xgx6qYwCeLEK1APgEaq7p9m3txt_QcGJt4_EV7wZiJI4aULb2dLEWWUlba1L-do6H5rAqXDB6Xn_MCWpWTZ2LWDLeWdy_NOy2GsRUivoHjRmUTN0yq2R-FWRxLrJwcEg9uucCJct2irFoEK-T_Ud4N0Be_5QnF08Gl2aEImRf23R_ZzeM1FfCYb9PNKdapuPHJSVU7EacT_MDA9UD9YwBAAA=

Logs

No response

System Info

Playground

Severity

annoyance
@rgon rgon mentioned this issue Oct 24, 2024
Closed
@dummdidumm dummdidumm reopened this Nov 2, 2024
@dummdidumm dummdidumm mentioned this issue Nov 2, 2024
Closed
@dummdidumm
Copy link
Member

Related #7807

dummdidumm added a commit that referenced this issue Nov 3, 2024
@dummdidumm
fix: correctly infer <a> tag namespace
7e70188 
 `<a>` tags are valid in both the SVG and HTML namespace.  If there's no parent, we therefore have to look downwards to see if it's the parent of a SVG or HTML element.

fixes #7807
fixes #13793
@dummdidumm dummdidumm mentioned this issue Nov 3, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly infer <a> tag namespace sveltejs/svelte
2 participants
@dummdidumm @matubu