Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross browser <:Window> scrollX / scrollY support #1175

Closed
arxpoetica opened this issue Feb 15, 2018 · 2 comments
Closed

Cross browser <:Window> scrollX / scrollY support #1175

arxpoetica opened this issue Feb 15, 2018 · 2 comments

Comments

@arxpoetica
Copy link
Member

See: https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY#Notes

I think it's right to leave the names as scrollX and scrollY in Svelte; but for backwards compatibility pageYOffset is more supported. We'll do both here.
@arxpoetica arxpoetica mentioned this issue Feb 15, 2018
Merged
@arxpoetica
Copy link
Member Author

Based on feedback, only doing pageYOffset and pageXOffset.

Rich-Harris added a commit that referenced this issue Feb 25, 2018
@Rich-Harris
Merge branch 'master' into gh-1175
e95a0b6
Rich-Harris added a commit that referenced this issue Feb 25, 2018
@Rich-Harris
Merge pull request #1176 from sveltejs/gh-1175
8aaf92a 
Using pageYOffset & pageXOffset
@Rich-Harris
Copy link
Member

Released 1.56.1 with the fix, thank you!

This was referenced Mar 14, 2018
Closed
Closed
Closed
Closed
Closed
Closed
@johanalkstal johanalkstal mentioned this issue Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arxpoetica @Rich-Harris