-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False "ownership_invalid_mutation" warning? #11525
Comments
Please provide a REPL with a proper reproduction, I can't reproduce this given the snippet. |
@dummdidumm Sorry about that, here's the most minimal reproduction repl I was able to do https://www.sveltelab.dev/3g1l3ut367jpkps Please note that the error doesn't get logged to the "server" console, it gets logged to the "client" console (aka browser dev tool console) |
When a proxy is reassigned, we call `$.proxy` again. There are cases where there's a component context set but the reassignment actually happens for variable that is ownerless within shared state or somewhere else. In that case we get false positives right now. The fix is to pass the previous value in to copy over the owners from it. Fixes #11525
When a proxy is reassigned, we call `$.proxy` again. There are cases where there's a component context set but the reassignment actually happens for variable that is ownerless within shared state or somewhere else. In that case we get false positives right now. The inverse is also true where reassigning can delete owners (because no component context exists) and result in false negatives. The fix is to pass the previous value in to copy over the owners from it. Fixes #11525
…11812) When a proxy is reassigned, we call `$.proxy` again. There are cases where there's a component context set but the reassignment actually happens for variable that is ownerless within shared state or somewhere else. In that case we get false positives right now. The inverse is also true where reassigning can delete owners (because no component context exists) and result in false negatives. The fix is to pass the previous value in to copy over the owners from it. Fixes #11525
Any updates on this ? I also get the same warning |
Describe the bug
Every time I tried to call the
show_toast
function from another component, I keep seeing Svelte log this to the console, is this a false warning?Reproduction
Toast.svelte
Logs
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: