-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[fix] propagate bindings correctly (#8114)
Fixes #8103 introduced through #7981 Keeps the infinite loop from happening but reopens #6298 and #5689
- Loading branch information
1 parent
1d658e7
commit 762d042
Showing
9 changed files
with
49 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<script> | ||
export let value; | ||
value = "bar"; | ||
</script> | ||
|
||
Child component "{value}"<br /> |
3 changes: 2 additions & 1 deletion
3
...ng-no-unnecessary-invalidation/_config.js → ...samples/binding-indirect-value/_config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
export default { | ||
async test({ assert, target }) { | ||
assert.htmlEqual(target.innerHTML, ` | ||
<p>0</p> | ||
Parent component "bar"<br /> | ||
Child component "bar"<br /> | ||
`); | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<script> | ||
import Component from "./Component.svelte"; | ||
let value = "foo"; | ||
</script> | ||
|
||
Parent component "{value}"<br /> | ||
<Component bind:value /> |
File renamed without changes.
10 changes: 10 additions & 0 deletions
10
test/runtime/samples/binding-no-unnecessary-invalidation.skip/_config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// this test currently fails because the fix that made it pass broke other tests, | ||
// see https://github.com/sveltejs/svelte/pull/8114 for more context. | ||
export default { | ||
skip: true, | ||
async test({ assert, target }) { | ||
assert.htmlEqual(target.innerHTML, ` | ||
<p>0</p> | ||
`); | ||
} | ||
}; |
File renamed without changes.