fix: allow testing browser code in node

sveltejs · Oct 29, 2024 · 47ae3ab · 47ae3ab
1 parent 4441952
commit 47ae3ab
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/packages/svelte/package.json b/packages/svelte/package.json
@@ -139,7 +139,7 @@
     "acorn-typescript": "^1.4.13",
     "aria-query": "^5.3.1",
     "axobject-query": "^4.1.0",
-    "esm-env": "^1.0.0",
+    "esm-env": "^1.1.1",
     "esrap": "^1.2.2",
     "is-reference": "^3.0.2",
     "locate-character": "^3.0.0",

diff --git a/packages/svelte/src/internal/client/timing.js b/packages/svelte/src/internal/client/timing.js
@@ -1,9 +1,10 @@
 /** @import { Raf } from '#client' */
 import { noop } from '../shared/utils.js';
 
-import { BROWSER } from 'esm-env';
+import { BROWSER, NODE } from 'esm-env';
 
-const request_animation_frame = BROWSER ? requestAnimationFrame : noop;
+// we check both conditions here to allow running browser code in Node for testing
+const request_animation_frame = BROWSER && !NODE ? requestAnimationFrame : noop;
 
 const now = BROWSER ? () => performance.now() : () => Date.now();
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml