-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: svelte-preprocess 6 #640
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6e314f9
breaking: remove TS mixed imports support, require TS 5.0 or higher
dummdidumm 3eae3e4
breaking: require Svelte 4+, Node 18+
dummdidumm d4fe906
chore: update CI
dummdidumm 7e2f419
fix: adjust type import
dummdidumm e2ecf07
chore: replace jest with vitest
dummdidumm 17bbc1c
chore: relax eslint config
dummdidumm 6cf3bc6
breaking: add exports map
dummdidumm 7518751
docs: migration info
dummdidumm 6d67d48
fix: remove pug types from dependencies
dummdidumm f1424a2
fix: allow TS filename to be undefined
dummdidumm 3e0cb1b
chore: get rid of magic-string as it's no longer used, bump node types
dummdidumm ebc2076
lint
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,12 +4,20 @@ | |
"license": "MIT", | ||
"main": "dist/index.js", | ||
"types": "dist/index.d.ts", | ||
"exports": { | ||
".": { | ||
"types": "./dist/index.d.ts", | ||
"default": "./dist/index.js" | ||
}, | ||
"./package.json": "./package.json" | ||
}, | ||
"description": "A Svelte preprocessor wrapper with baked-in support for commonly used preprocessors", | ||
"author": "Christian Kaisermann <[email protected]>", | ||
"repository": "https://github.com/sveltejs/svelte-preprocess", | ||
"keywords": [ | ||
"svelte", | ||
"preprocess", | ||
"typescript", | ||
"less", | ||
"stylus", | ||
"sass", | ||
|
@@ -18,9 +26,9 @@ | |
"coffeescript" | ||
], | ||
"engines": { | ||
"node": ">= 16.0.0" | ||
"node": ">= 18.0.0" | ||
}, | ||
"packageManager": "pnpm@8.12.1", | ||
"packageManager": "pnpm@9.3.0", | ||
"volta": { | ||
"node": "20.10.0" | ||
}, | ||
|
@@ -31,7 +39,7 @@ | |
"prebuild": "node scripts.js rmrf ./dist", | ||
"build": "tsc --build tsconfig.build.json", | ||
"dev": "pnpm build -w", | ||
"test": "jest", | ||
"test": "vitest run", | ||
"lint": "eslint --ext js,ts .", | ||
"format": "prettier --write \"**/*.{ts,js,json}\"", | ||
"postinstall": "echo \"[svelte-preprocess] Don't forget to install the preprocessors packages that will be used: sass, stylus, less, postcss & postcss-load-config, coffeescript, pug, etc...\"", | ||
|
@@ -46,15 +54,6 @@ | |
"@commitlint/config-conventional" | ||
] | ||
}, | ||
"lint-staged": { | ||
"*.{ts,js,tsx,jsx}": [ | ||
"eslint --fix", | ||
"prettier --write" | ||
], | ||
"*.json": [ | ||
"prettier --write" | ||
] | ||
}, | ||
"devDependencies": { | ||
"@babel/core": "^7.23.6", | ||
"@babel/preset-env": "^7.23.6", | ||
|
@@ -63,48 +62,43 @@ | |
"@kiwi/eslint-config": "^2.0.2", | ||
"@kiwi/prettier-config": "^2.0.2", | ||
"@types/babel__core": "^7.20.5", | ||
"@types/jest": "^27.5.2", | ||
"@types/node": "^14.18.34", | ||
"@types/node": "^18.0.0", | ||
"@types/pug": "^2.0.6", | ||
"@types/stylus": "^0.48.38", | ||
"autoprefixer": "^10.4.16", | ||
"babel-minify": "^0.5.2", | ||
"coffeescript": "^2.7.0", | ||
"conventional-changelog-cli": "^2.2.2", | ||
"eslint": "^8.29.0", | ||
"jest": "^29.5.0", | ||
"less": "^3.13.1", | ||
"lint-staged": "^10.5.4", | ||
"postcss": "^8.4.32", | ||
"postcss-easy-import": "^4.0.0", | ||
"postcss-load-config": "^3.1.4", | ||
"prettier": "^2.8.1", | ||
"prettier": "^3.3.2", | ||
"pug": "^3.0.2", | ||
"sass": "^1.56.2", | ||
"stylus": "^0.55.0", | ||
"sugarss": "^4.0.0", | ||
"svelte": "^3.54.0", | ||
"ts-jest": "^29.1.1", | ||
"typescript": "^5.0.2" | ||
"svelte": "^4.0.0", | ||
"typescript": "^5.0.2", | ||
"vitest": "^1.6.0" | ||
}, | ||
"dependencies": { | ||
"@types/pug": "^2.0.6", | ||
"detect-indent": "^6.1.0", | ||
"magic-string": "^0.30.5", | ||
"sorcery": "^0.11.0", | ||
"strip-indent": "^3.0.0" | ||
}, | ||
"peerDependencies": { | ||
"@babel/core": "^7.10.2", | ||
"coffeescript": "^2.5.1", | ||
"less": "^3.11.3 || ^4.0.0", | ||
"postcss": "^7 || ^8", | ||
"postcss-load-config": "^2.1.0 || ^3.0.0 || ^4.0.0 || ^5.0.0", | ||
"postcss-load-config": ">=3", | ||
"pug": "^3.0.0", | ||
"sass": "^1.26.8", | ||
"stylus": "^0.55.0", | ||
"stylus": ">=0.55", | ||
"sugarss": "^2.0.0 || ^3.0.0 || ^4.0.0", | ||
"svelte": "^3.23.0 || ^4.0.0-next.0 || ^4.0.0 || ^5.0.0-next.0", | ||
"typescript": ">=3.9.5 || ^4.0.0 || ^5.0.0" | ||
"svelte": "^4.0.0 || ^5.0.0-next.100 || ^5.0.0", | ||
"typescript": "^5.0.0" | ||
}, | ||
"peerDependenciesMeta": { | ||
"@babel/core": { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to do this in our packages anymore. It was a result of how our bundler plugins worked, but they've since been fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better safe than sorry - I'm not sure if rollup-plugin-svelte and svelte-loader can handle it yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we updated them. Doesn't matter much, but figured I'd let you know