Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefixed @keyframes are being incorrectly globalified #264

Closed
kaisermann opened this issue Oct 5, 2020 · 0 comments · Fixed by #265
Closed

Prefixed @keyframes are being incorrectly globalified #264

kaisermann opened this issue Oct 5, 2020 · 0 comments · Fixed by #265
Assignees
@kaisermann
Labels
bug Something isn't working

Comments

@kaisermann
Copy link
Member

kaisermann commented Oct 5, 2020 •
edited
Loading

Describe the bug

When using prefixed @keyframes, such as @-webkit-keyframes { ... }, the globalStyle transformer tries to wrap its inner selectors (from, to, n%, etc) with :global.

Logs
Please include browser console and server logs around the time this bug occurred.

To Reproduce

As described by @floratmin: https://github.com/floratmin/svelte-autoprefixer-example

See #253

Expected behavior

Prefixed keyframes should work exactly as non-prefixed ones.
@kaisermann kaisermann added the bug Something isn't working label Oct 5, 2020
@kaisermann kaisermann self-assigned this Oct 5, 2020
kaisermann added a commit that referenced this issue Oct 5, 2020
@kaisermann
fix: 🐛 prefixed keyframes globalization
903d95b 
✅ Closes: #264
@kaisermann kaisermann mentioned this issue Oct 5, 2020
Merged
kaisermann added a commit that referenced this issue Oct 5, 2020
@kaisermann
fix: 🐛 prefixed keyframes globalization
cdb5ae4 
✅ Closes: #264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaisermann kaisermann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 prefixed keyframes globalization sveltejs/svelte-preprocess
1 participant
@kaisermann