fix: escape paths in injected imports #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think if the MacOS tests are passing then you should be safe. I don't know what's going on with the Ubuntu tests, but it seems like a separate issue |
benmccann
approved these changes
Aug 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77. We can't just wrap the
hotApiImportandadapterImportpaths in single quotes, because any single quotes inside of them will result in invalid code being generated. I'm instead running them throughJSON.stringify.I'm unable to get the tests to run locally, so I haven't run the tests and I don't know whether this breaks anything. I haven't tried running them with older versions of Node, but it also looks like CI has been red on master for a while.
This repo is also on an old version of pnpm that does not work in Node 20.