Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[...spread] routes #607

Merged
merged 4 commits into from
Apr 29, 2019
Merged

[...spread] routes #607

merged 4 commits into from
Apr 29, 2019

Conversation

cudr
Copy link
Contributor

@cudr cudr commented Mar 13, 2019

implement #545

@cudr
Copy link
Contributor Author

cudr commented Apr 9, 2019

Important notice: changes in the comparator function only work on node 11 and above, see nodejs/node#24294

@Rich-Harris
Copy link
Member

Thanks @cudr, this is great news — though I'm not sure I understand the comment about the comparator function. Are you saying Sapper's behaviour would differ between Node 10 and 11 with this PR?

@cudr
Copy link
Contributor Author

cudr commented Apr 27, 2019

@Rich-Harris Yes, there was some uncertainty due to which the comparator function behaved differently between 10 and 11. Now more tests are added and it works the same way on both 10 and 11 versions of the nodejs

@Rich-Harris Rich-Harris merged commit e07c27a into sveltejs:master Apr 29, 2019
@Rich-Harris
Copy link
Member

awesome, thanks

@Conduitry Conduitry mentioned this pull request Feb 19, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cudr @Rich-Harris