This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fix Sapper on Windows #1338
Merged
Fix Sapper on Windows #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
windows
branch
4 times, most recently
from
69f196f to
18cafc6
Compare
This was referenced Jul 26, 2020
Closed
antony
reviewed
Jul 29, 2020
|
Added a test |
antony
suggested changes
Jul 29, 2020
antony
approved these changes
Jul 29, 2020
habibrosyad
pushed a commit
to habibrosyad/sapper
that referenced
this pull request
Aug 4, 2020
trmcnvn
pushed a commit
to metafy-gg/sapper
that referenced
this pull request
Aug 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1333
Fixes #1256
It might only affect some versions of Windows since the tests were passing on GitHub Actions without this change
Thanks to @Shackless for remote debugging this with me and testing!