This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Prevent server restarting while restart in progress #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
May 27, 2020
src/api/dev.ts
Outdated
| @@ -310,11 +310,14 @@ class Watcher extends EventEmitter { | |||
| }; | |||
|
|
|||
| if (this.proc) { | |||
| if (this.restarting) return; | |||
There was a problem hiding this comment.
these spaces should be tabs for consistency with the existing code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #920
The issue was caused by the server file watcher process calling
handle_resultin rapid succession. The source of this could be IDEs making many file saves (I only saw the issue in VSCode not vim), or just caused by people with an itchy cmd+S finger.Initially considered debouncing the
handle_resultmethod, but a simple flag seems to be sufficient.Flag was added inside the callback code for server changes and it prevents the server restart process if the flag is true.