Merge pull request #603 from sveltejs/gh-602

fix handling of empty hrefs during export
sveltejs · Apr 27, 2019 · 90ec61f · 90ec61f
2 parents 4f9919e + 6d5aa9a
commit 90ec61f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/api/export.ts b/src/api/export.ts
@@ -212,6 +212,6 @@ async function _export({
 }
 
 function get_href(attrs: string) {
-	const match = /href\s*=\s*(?:"(.*?)"|'(.+?)'|([^\s>]+))/.exec(attrs);
-	return match[1] || match[2] || match[3];
+	const match = /href\s*=\s*(?:"(.*?)"|'(.*?)'|([^\s>]*))/.exec(attrs);
+	return match && (match[1] || match[2] || match[3]);
 }
diff --git a/test/apps/export/src/routes/index.svelte b/test/apps/export/src/routes/index.svelte
@@ -1,4 +1,9 @@
 <h1>Great success!</h1>
 
 <a href="blog">blog</a>
-<a href="">empty anchor</a>
+<a href="">empty anchor</a>
+<a href=''>empty anchor #2</a>
+<a href=>empty anchor #3</a>
+<a href= >empty anchor #4</a>
+<a href>empty anchor #5</a>
+<a>empty anchor #6</a>