Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

[Sapper #1151] Updated rollup dependencies #221

Merged
merged 4 commits into from
May 22, 2020
Merged

Conversation

arxpoetica
Copy link
Member

@arxpoetica arxpoetica commented May 3, 2020

This is not ready for merging until an issue for @rollup/plugin-commonjs is fixed, which should be any day: rollup/plugins#304

Before merging this PR should update that dependency to the fix first.

Relevant Sapper issue: sveltejs/sapper#1151

Will also fix: #218

@arxpoetica arxpoetica requested a review from Conduitry May 3, 2020 19:00
@antony
Copy link
Member

antony commented May 12, 2020

Note that preserveEntrySignatures: false on the server bundle stops you exporting the Polka handler, and thus breaks the app in serverless environments.

It should probably be 'strict' in this instance.

@antony
Copy link
Member

antony commented May 19, 2020

@arxpoetica @Conduitry I think we can just merge this and keep the commonjs version locked. This is how I have it set up in my own Sapper projects, and it works.

FWIW I can't figure out what is happening with the issue in rollup, it appears to have been "fixed" but still doesn't work, and anybody asking when it will work receives a gif as an answer. I can't make head nor tail of it, maybe somebody else understands what needs to be done?

@antony
Copy link
Member

antony commented May 19, 2020

A bit of further investigation seems to indicate sapper-dev-server.js as the culprit in our case, but I'm not sure why @rollup/plugin-commonjs is bothering with that file anyway.

@benmccann
Copy link
Member

It looks like @rollup/plugin-commonjs 12.0.0 is out now

@@ -2,7 +2,7 @@ import resolve from '@rollup/plugin-node-resolve';
import replace from '@rollup/plugin-replace';
import commonjs from '@rollup/plugin-commonjs';
import svelte from 'rollup-plugin-svelte';
import babel from 'rollup-plugin-babel';
import babel from '@rollup/plugin-babel';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this move to the top to be alphabetized?

@antony
Copy link
Member

antony commented May 22, 2020

Can confirm that @rollup/[email protected] works without issue 🍾

@arxpoetica if you don't mind upgrading the library in this PR, I believe it's ready to merge.

Conduitry added 2 commits May 22, 2020 08:44
Also update rollup, as the commonjs plugin has an updated peerDep.
@Conduitry Conduitry marked this pull request as ready for review May 22, 2020 12:48
@Conduitry Conduitry merged commit cf20533 into master May 22, 2020
@Conduitry Conduitry deleted the gh-sapper-1151 branch May 22, 2020 12:49
@arxpoetica
Copy link
Member Author

w00t! Thanks for taking initiative on this @Conduitry @benmccann @antony

I was asleep at the wheel :P

@mcmxcdev
Copy link
Contributor

I think #225 can be closed due to this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup 2: warning: preserveEntrySignatures
5 participants