Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

Live reload not working out of box in roll up template #212

Closed
stolinski opened this issue Apr 16, 2020 · 6 comments
Closed

Live reload not working out of box in roll up template #212

stolinski opened this issue Apr 16, 2020 · 6 comments

Comments

@stolinski
Copy link
Contributor

I followed the instructions here:
https://sapper.svelte.dev/docs#Getting_started

and don't have any kind of live reloading working when making changes to any files. Build process is showing changes, no reloading taking place on the client. attempted in Chrome and Brave. Live reloading works on other platforms without issue.

Network tab shows a failed request for http://localhost:3000/client/undefined not sure if these are related.

@stolinski
Copy link
Contributor Author

Seems to be the same issue here: sveltejs/sapper#1151

@Conduitry
Copy link
Member

Yes, the issue is that no javascript is running at all, because the build fails due to presumably a bug in that Rollup plugin.

@stolinski
Copy link
Contributor Author

JW why this got closed if it's still a bug.

@Conduitry
Copy link
Member

Because there's another issue for it.

@stolinski
Copy link
Contributor Author

stolinski commented Apr 16, 2020

Sure, but not in regards to the templates. If a fix is a pinned version in the template, shouldn't that be tracked here until a fix is in?

For the past bit anyone trying Sapper for the first time has a broken experience OOTB and might come here looking for open issues.🤷‍♂️

stolinski added a commit to stolinski/sapper-template that referenced this issue Apr 16, 2020
Anyone trying Sapper is going to have a bad time rn. Until the roll up plugin is fixed, the fix posted here: sveltejs/sapper#1151 is a good temp patch.
@stolinski
Copy link
Contributor Author

stolinski commented Apr 16, 2020

I created a temp fix for this just to prevent first time users from seeing broken code OOTB.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants