Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix svelte compiler preprocess option type #118

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fix svelte compiler preprocess option type #118

merged 1 commit into from
Aug 3, 2020

Conversation

maxmilton
Copy link
Contributor

Fixes #117

@maxmilton maxmilton mentioned this pull request Jul 27, 2020
Merged
@benmccann
Copy link
Member

lgtm. for reference:

https://github.com/sveltejs/svelte/blob/e6026fe6f53ecd5414e5dfaf903e0c75005b9c2b/src/compiler/preprocess/index.ts#L72

@benmccann benmccann merged commit 97dbb86 into sveltejs:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@lukeed lukeed lukeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"preprocess" types not compatible with Svelte's types
3 participants
@maxmilton @benmccann @lukeed