(feat) Add support for svelte-jsx.d.ts and svelte-native-jsx.d.ts to emitDts #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emitDts The svelte.JSX namespace, and in particular the svelte.JSX.HTMLAttributes interface, is used by several component libraries. But SvelteKit's package command will fail for components that use them because these definitions are missing. See kit#3783
rgossiaux
commented
Mar 9, 2022
| @@ -5,6 +5,8 @@ import { svelte2tsx } from './svelte2tsx'; | |||
| export interface EmitDtsConfig { | |||
| declarationDir: string; | |||
| svelteShimsPath: string; | |||
| svelteJsxPath?: string; | |||
| svelteNativeJsxPath?: string; | |||
There was a problem hiding this comment.
Another option is adding a [string] option for additional paths instead of just listing these out individually, and another alternative is emitDts just finding & reading these itself (I wasn't sure why it's structured this way right now). Another option is combining all of the declarations into one file.
Obviously you folks would know best, I just opened this PR to get the ball rolling.
dummdidumm
pushed a commit
to dummdidumm/language-tools
that referenced
this pull request
Mar 14, 2022
Needed when someone uses the svelte.JSX typings. Closes sveltejs#1405
|
Closing as the svelte.JSX namespace is now deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The svelte.JSX namespace, and in particular the svelte.JSX.HTMLAttributes interface, is used by several component libraries. But SvelteKit's package command will fail for components that use them because these definitions are missing. See kit#3783