Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svelte2tsx to handle @const #1072

Merged
merged 11 commits into from
Jan 13, 2022
Merged

svelte2tsx to handle @const #1072

merged 11 commits into from
Jan 13, 2022

Conversation

tanhauhau
Copy link
Member

Fixes #1067

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-1067 branch from f611083 to 3d8db45 Compare June 21, 2021 07:42
@dummdidumm
Copy link
Member

Oh wow, thank you very much for this 🎉 From a quick glance this looks good.

Notes to self on what to check:

  • how it behaves when there are #if blocks in the parent, possibly with conflicting names
  • quick check on rename/diagnostics/go to definition work and possibly adding tests, at least for the diagnostics

@dummdidumm dummdidumm mentioned this pull request Jan 12, 2022
Closed
@dimfeld dimfeld mentioned this pull request Jan 12, 2022
Closed
@dummdidumm dummdidumm merged commit 7c7f9d7 into sveltejs:master Jan 13, 2022
@tanhauhau tanhauhau deleted the tanhauhau/gh-1067 branch January 13, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for @const feature
2 participants
@tanhauhau @dummdidumm