-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tsconfig option in svelte2tsx emitDts #2355
Labels
feature request
New feature or request
Comments
Sorry for the late reply - this makes total sense, contributions welcome! |
Tracking stuff to do:
|
Closing since both tasks are done - thanks again! |
dummdidumm
pushed a commit
to sveltejs/kit
that referenced
this issue
Sep 6, 2024
Handles second task of sveltejs/language-tools#2355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
When working in a monorepository, it is possible to end up with the following structure:
This allows a few things:
Issue
This is almost possible currently, as svelte-package supports a tsconfig option. However, the function
emitDts
from svelte2tsx does not support an input tsconfig path, so this results in unexpected behavior.A reproduction repo to see the issue in action:
https://github.com/quentinderoubaix/showcase-tsconfig/tree/main
Proposed solution
Allow an extra option
tsconfig
inemitDts
of package svelte2tsx + update svelte-package in svelte-kit to use it.Alternatives
No response
Additional Information, eg. Screenshots
If this issue is deemed valid, I would be down to contribute in both this repo and kit to handle it.
The text was updated successfully, but these errors were encountered: