Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tsconfig option in svelte2tsx emitDts #2355

Closed
quentinderoubaix opened this issue Apr 29, 2024 · 3 comments
Closed

Support tsconfig option in svelte2tsx emitDts #2355

quentinderoubaix opened this issue Apr 29, 2024 · 3 comments
Labels
feature request New feature or request

Comments

@quentinderoubaix
Copy link
Contributor

quentinderoubaix commented Apr 29, 2024

Context

When working in a monorepository, it is possible to end up with the following structure:

  • package-a
    • tsconfig.json
  • package-b ➡️ depends on package-a
    • tsconfig.json ➡️ uses compiler path option to target the sources of package-a
    • tsconfig.build.json ➡️ no compiler path option

This allows a few things:

  • when checking any source file of package-b in your favorite IDE, navigating to a reference of package-a would open the source file, not the dist file
  • in the script commands of package-b, svelte-package and svelte-check can use tsconfig.build.json to make sure package-a is not re-transpiled

Issue

This is almost possible currently, as svelte-package supports a tsconfig option. However, the function emitDts from svelte2tsx does not support an input tsconfig path, so this results in unexpected behavior.

A reproduction repo to see the issue in action:
https://github.com/quentinderoubaix/showcase-tsconfig/tree/main

Proposed solution

Allow an extra option tsconfig in emitDts of package svelte2tsx + update svelte-package in svelte-kit to use it.

Alternatives

No response

Additional Information, eg. Screenshots

If this issue is deemed valid, I would be down to contribute in both this repo and kit to handle it.

@dummdidumm dummdidumm added the feature request New feature or request label Jul 31, 2024
@dummdidumm
Copy link
Member

Sorry for the late reply - this makes total sense, contributions welcome!

@quentinderoubaix
Copy link
Contributor Author

quentinderoubaix commented Aug 1, 2024

Tracking stuff to do:

  • add tsconfig option in emitDts
  • pass through the tsconfig option in svelte-package

@dummdidumm
Copy link
Member

Closing since both tasks are done - thanks again!

dummdidumm pushed a commit to sveltejs/kit that referenced this issue Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants