fix: preserve bind:... mapping on elements for better source maps

else an error like "X is not assignable to bind:Y" is shown on the previous attribute, if there is one
sveltejs · Nov 22, 2024 · cda5c86 · cda5c86
1 parent be44125
commit cda5c86
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/packages/svelte2tsx/src/htmlxtojsx_v2/nodes/Binding.ts b/packages/svelte2tsx/src/htmlxtojsx_v2/nodes/Binding.ts
@@ -114,12 +114,7 @@ export function handleBinding(
             ? // HTML typings - preserve the bind: prefix
               isShorthand
                 ? [`"${str.original.substring(attr.start, attr.end)}"`]
-                : [
-                      `"${str.original.substring(
-                          attr.start,
-                          str.original.lastIndexOf('=', attr.expression.start)
-                      )}"`
-                  ]
+                : ['"', [attr.start, str.original.lastIndexOf('=', attr.expression.start)], '"']
             : // Other typings - remove the bind: prefix
               isShorthand
               ? [[attr.expression.start, attr.expression.end]]

diff --git a/packages/svelte2tsx/test/htmlx2jsx/samples/binding/expected-svelte5.js b/packages/svelte2tsx/test/htmlx2jsx/samples/binding/expected-svelte5.js