Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for server-emitted assets when prerendering #9349

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

Rich-Harris
Copy link
Member

closes #9146. I couldn't quite get to the bottom of the specifics of that issue's reproduction, because some very strange things were happening that resulted in missing assets in `output/client. I think there's another bug somewhere, possibly in the bowels of Vite, but it eluded me.

Anyway, the prerenderer isn't taking account of server-emitted assets, and this PR fixes it.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@dummdidumm
Copy link
Member

chirp chirp

@dummdidumm dummdidumm merged commit daad7e4 into master Mar 8, 2023
@dummdidumm dummdidumm deleted the gh-9146 branch March 8, 2023 13:24
@github-actions github-actions bot mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during site building
2 participants