-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed getStaticDirectory() #7809
Conversation
🦋 Changeset detectedLatest commit: 1a22ec3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It seems svelte-adapter-firebase has one usage. |
Thank you! We should ask them for what exactly they need it and if they can use something else to achieve what they want before merging this. |
@jthegedus it would be interesting to get your input on this PR. thanks! |
We are using this in the Firebase adapter to resolve #587 in our own way, but I believe we can work around it regardless. I need to do a big update/rewrite of the adapter now a lot of things have changed in Firebase and Kit. Thanks for the consideration Ben 🙏 |
thank you! |
@jthegedus I was just reading your comment (#587 (comment)) on that issue to make sure we didn't cause you any trouble by merging this. What I would recommend is copying the assets from the output directory. The output directory will contain both the generated application files and assets from the |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Removes getStaticDirectory() because of no more usage, as stated in #7800.
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0