Fix query params being empty #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
reviewed
Mar 30, 2021
wiesson
force-pushed
the
fix/vercel-adapter-query-params
branch
from
4578449
to
03d67ac
Compare
|
The previous job was successful, I could imagine that somekind of race condition happened because I force pushed to the branch 🤷♂️ https://github.com/sveltejs/kit/actions/runs/701770695 |
|
If this is broken, then I'm guessing kit/packages/adapter-node/src/server.js Line 40 in 8024178 Strange that this would only be reported now... |
|
Ah, nevermind. |
|
Should I include that in this PR as well or create a new one? |
benmccann
force-pushed
the
fix/vercel-adapter-query-params
branch
2 times, most recently
from
168b850
to
e536fa9
Compare
benmccann
force-pushed
the
fix/vercel-adapter-query-params
branch
from
e536fa9
to
7c1cef4
Compare
|
I've updated this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #631
The query params are not parsed correctly, because
URLdoes not returnquery- instead it returns the desired searchParams!Tested here - https://sveltekit-vercel.vercel.app/queryparams?q=pizza